WIP: chore(rust/sedona-spatial-join) Reimplement planner for spatial join#562
Draft
Kontinuation wants to merge 12 commits intoapache:mainfrom
Draft
WIP: chore(rust/sedona-spatial-join) Reimplement planner for spatial join#562Kontinuation wants to merge 12 commits intoapache:mainfrom
Kontinuation wants to merge 12 commits intoapache:mainfrom
Conversation
A working version At least, it is working Reworked compute_properties to faithfully reflect the actual properties of join outputs docs(rust/sedona-spatial-join): annotate forked join_utils changes Add tests for plan properties computation utilities Reorganized planner code More refactoring, now it is in a good state docs(rust/sedona-spatial-join): document planner modules Don't fallback to the default planner to generate nested loop join. Implement our own logical join filter -> physical join filter transformation Skeleton for implementing projection pushdown and input swapping
Kontinuation
force-pushed
the
spatial-join-planner
branch
from
7f1d783 to
de39f3e
Compare
Guard join projection pushdown behavior after moving the helper into join utils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #282
Emit
SpatialJoinExecdirectly from logical plan instead of performing the error-prone physical -> physical plan translation (NestedLoopJoinExec/HashJoinExec -> SpatialJoinExec). We follow the standard practice of doing this in DataFusion, see https://github.com/apache/datafusion/blob/52.1.0/datafusion/core/tests/user_defined/user_defined_plan.rsWe have also revised the plan properties of SpatialJoinExec. The plan properties were all wrong for KNN join, this patch fixed that and make sure that we won't break the data distribution enforcement.